Skip to content

Have MsgsBetweenSeqNums populate TxHash #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Have MsgsBetweenSeqNums populate TxHash #1337

wants to merge 2 commits into from

Conversation

@rstout
Copy link
Contributor

@rstout rstout commented Oct 29, 2025 •
edited
Loading

We need TxHash in order to call CCTPv2's HTTP API: https://developers.circle.com/api-reference/cctp/all/get-messages-v-2

@rstout rstout requested a review from a team as a code owner October 29, 2025 17:45
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

👋 rstout, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Metric add-msg-tx-hash main
Coverage 69.9% 68.7%

@ogtownsend
Copy link
Contributor

ogtownsend commented Nov 3, 2025

TxHash is left out of several of the exec codecs, will this be a problem? Example:

@rstout
Copy link
Contributor Author

rstout commented Nov 5, 2025

TxHash is left out of several of the exec codecs, will this be a problem? Example:

It shouldn't be, the codecs are for encoding/decoding reports, and TxHash doesn't need to be included in the reports. The place that needs to populate TxHash is the chain readers, and this seems to be the case, so TxHash should be populated.

ogtownsend
ogtownsend approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ogtownsend ogtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogtownsend ogtownsend ogtownsend approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain

@tt-cll tt-cll Awaiting requested review from tt-cll tt-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 2 approving reviews are required to merge this pull request.

Assignees

@winder winder

@ogtownsend ogtownsend

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rstout @ogtownsend @winder